1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
use move_binary_format::{
errors::{PartialVMError, PartialVMResult},
file_format::{Bytecode, CodeOffset, CodeUnit, FunctionDefinitionIndex},
};
use move_core_types::vm_status::StatusCode;
use std::{collections::HashSet, convert::TryInto};
pub fn verify(
current_function_opt: Option<FunctionDefinitionIndex>,
code: &CodeUnit,
) -> PartialVMResult<()> {
let current_function = current_function_opt.unwrap_or(FunctionDefinitionIndex(0));
match code.code.last() {
None => return Err(PartialVMError::new(StatusCode::EMPTY_CODE_UNIT)),
Some(last) if !last.is_unconditional_branch() => {
return Err(PartialVMError::new(StatusCode::INVALID_FALL_THROUGH)
.at_code_offset(current_function, (code.code.len() - 1) as CodeOffset))
}
Some(_) => (),
}
let context = &ControlFlowVerifier {
current_function,
code: &code.code,
};
let labels = instruction_labels(context);
check_jumps(context, labels)
}
#[derive(Clone, Copy)]
enum Label {
Loop { last_continue: u16 },
Code,
}
struct ControlFlowVerifier<'a> {
current_function: FunctionDefinitionIndex,
code: &'a Vec<Bytecode>,
}
impl<'a> ControlFlowVerifier<'a> {
fn code(&self) -> impl Iterator<Item = (CodeOffset, &'a Bytecode)> {
self.code
.iter()
.enumerate()
.map(|(idx, instr)| (idx.try_into().unwrap(), instr))
}
fn labeled_code<'b: 'a>(
&self,
labels: &'b [Label],
) -> impl Iterator<Item = (CodeOffset, &'a Bytecode, &'b Label)> {
self.code()
.zip(labels)
.map(|((i, instr), lbl)| (i, instr, lbl))
}
fn error(&self, status: StatusCode, offset: CodeOffset) -> PartialVMError {
PartialVMError::new(status).at_code_offset(self.current_function, offset)
}
}
fn instruction_labels(context: &ControlFlowVerifier) -> Vec<Label> {
let mut labels: Vec<Label> = (0..context.code.len()).map(|_| Label::Code).collect();
let mut loop_continue = |loop_idx: CodeOffset, last_continue: CodeOffset| {
labels[loop_idx as usize] = Label::Loop { last_continue }
};
for (i, instr) in context.code() {
match instr {
Bytecode::Branch(prev) | Bytecode::BrTrue(prev) | Bytecode::BrFalse(prev)
if *prev <= i =>
{
loop_continue(*prev, i)
}
_ => (),
}
}
labels
}
fn check_jumps(context: &ControlFlowVerifier, labels: Vec<Label>) -> PartialVMResult<()> {
check_continues(context, &labels)?;
check_breaks(context, &labels)?;
check_no_loop_splits(context, &labels)
}
fn check_code<
F: FnMut(&Vec<(CodeOffset, CodeOffset)>, CodeOffset, &Bytecode) -> PartialVMResult<()>,
>(
context: &ControlFlowVerifier,
labels: &[Label],
mut check: F,
) -> PartialVMResult<()> {
let mut loop_stack: Vec<(CodeOffset, CodeOffset)> = vec![];
for (i, instr, label) in context.labeled_code(labels) {
if let Label::Loop { last_continue } = label {
loop_stack.push((i, *last_continue));
}
check(&loop_stack, i, instr)?;
match instr {
Bytecode::Branch(j) | Bytecode::BrTrue(j) | Bytecode::BrFalse(j) if *j <= i => {
let (_cur_loop, last_continue) = loop_stack.last().unwrap();
if i == *last_continue {
loop_stack.pop();
}
}
_ => (),
}
}
Ok(())
}
fn check_continues(context: &ControlFlowVerifier, labels: &[Label]) -> PartialVMResult<()> {
check_code(context, labels, |loop_stack, i, instr| {
match instr {
Bytecode::Branch(j) | Bytecode::BrTrue(j) | Bytecode::BrFalse(j) if *j <= i => {
let (cur_loop, _last_continue) = loop_stack.last().unwrap();
let is_continue = *j <= i;
if is_continue && j != cur_loop {
Err(context.error(StatusCode::INVALID_LOOP_CONTINUE, i))
} else {
Ok(())
}
}
_ => Ok(()),
}
})
}
fn check_breaks(context: &ControlFlowVerifier, labels: &[Label]) -> PartialVMResult<()> {
check_code(context, labels, |loop_stack, i, instr| {
match instr {
Bytecode::Branch(j) | Bytecode::BrTrue(j) | Bytecode::BrFalse(j) if *j > i => {
match loop_stack.last() {
Some((_cur_loop, last_continue))
if j > last_continue && *j != last_continue + 1 =>
{
Err(context.error(StatusCode::INVALID_LOOP_BREAK, i))
}
_ => Ok(()),
}
}
_ => Ok(()),
}
})
}
fn check_no_loop_splits(context: &ControlFlowVerifier, labels: &[Label]) -> PartialVMResult<()> {
let is_break = |loop_stack: &Vec<(CodeOffset, CodeOffset)>, jump_target: CodeOffset| -> bool {
match loop_stack.last() {
None => false,
Some((_cur_loop, last_continue)) => jump_target > *last_continue,
}
};
let loop_depth = count_loop_depth(labels);
check_code(context, labels, |loop_stack, i, instr| {
match instr {
Bytecode::Branch(j) | Bytecode::BrTrue(j) | Bytecode::BrFalse(j)
if *j > i && !is_break(loop_stack, *j) =>
{
let j = *j;
let before_depth = loop_depth[i as usize];
let after_depth = match &labels[j as usize] {
Label::Loop { .. } => loop_depth[j as usize] - 1,
Label::Code => loop_depth[j as usize],
};
if before_depth != after_depth {
Err(context.error(StatusCode::INVALID_LOOP_SPLIT, i))
} else {
Ok(())
}
}
_ => Ok(()),
}
})
}
fn count_loop_depth(labels: &[Label]) -> Vec<usize> {
let last_continues: HashSet<CodeOffset> = labels
.iter()
.filter_map(|label| match label {
Label::Loop { last_continue } => Some(*last_continue),
Label::Code => None,
})
.collect();
let mut count = 0;
let mut counts = vec![];
for (idx, label) in labels.iter().enumerate() {
if let Label::Loop { .. } = label {
count += 1
}
counts.push(count);
if last_continues.contains(&idx.try_into().unwrap()) {
count -= 1;
}
}
counts
}