1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
use move_binary_format::{
access::ModuleAccess,
errors::{Location, PartialVMError, PartialVMResult, VMResult},
file_format::{
Bytecode, CompiledModule, FunctionDefinition, FunctionDefinitionIndex, FunctionHandleIndex,
SignatureIndex, SignatureToken, TypeParameterIndex,
},
};
use move_core_types::vm_status::StatusCode;
use petgraph::{
algo::tarjan_scc,
graph::{EdgeIndex, NodeIndex},
visit::EdgeRef,
Graph,
};
use std::collections::{hash_map, HashMap, HashSet};
#[derive(Eq, PartialEq, Hash, Copy, Clone)]
struct Node(FunctionDefinitionIndex, TypeParameterIndex);
enum Edge<'a> {
Identity,
TyConApp(&'a SignatureToken),
}
pub struct InstantiationLoopChecker<'a> {
module: &'a CompiledModule,
graph: Graph<Node, Edge<'a>>,
node_map: HashMap<Node, NodeIndex>,
func_handle_def_map: HashMap<FunctionHandleIndex, FunctionDefinitionIndex>,
}
impl<'a> InstantiationLoopChecker<'a> {
fn new(module: &'a CompiledModule) -> Self {
Self {
module,
graph: Graph::new(),
node_map: HashMap::new(),
func_handle_def_map: module
.function_defs()
.iter()
.enumerate()
.map(|(def_idx, def)| (def.function, FunctionDefinitionIndex::new(def_idx as u16)))
.collect(),
}
}
pub fn verify_module(module: &'a CompiledModule) -> VMResult<()> {
Self::verify_module_impl(module).map_err(|e| e.finish(Location::Module(module.self_id())))
}
fn verify_module_impl(module: &'a CompiledModule) -> PartialVMResult<()> {
let mut checker = Self::new(module);
checker.build_graph();
let mut components = checker.find_non_trivial_components();
match components.pop() {
None => Ok(()),
Some((nodes, edges)) => {
let msg_edges = edges
.into_iter()
.filter_map(
|edge_idx| match checker.graph.edge_weight(edge_idx).unwrap() {
Edge::TyConApp(_) => Some(checker.format_edge(edge_idx)),
_ => None,
},
)
.collect::<Vec<_>>()
.join(", ");
let msg_nodes = nodes
.into_iter()
.map(|node_idx| checker.format_node(node_idx))
.collect::<Vec<_>>()
.join(", ");
let msg = format!(
"edges with constructors: [{}], nodes: [{}]",
msg_edges, msg_nodes
);
Err(PartialVMError::new(StatusCode::LOOP_IN_INSTANTIATION_GRAPH).with_message(msg))
}
}
}
fn get_or_add_node(&mut self, node: Node) -> NodeIndex {
match self.node_map.entry(node) {
hash_map::Entry::Occupied(entry) => *entry.get(),
hash_map::Entry::Vacant(entry) => {
let idx = self.graph.add_node(node);
entry.insert(idx);
idx
}
}
}
fn extract_type_parameters(&self, ty: &SignatureToken) -> HashSet<TypeParameterIndex> {
use SignatureToken::*;
let mut type_params = HashSet::new();
fn rec(type_params: &mut HashSet<TypeParameterIndex>, ty: &SignatureToken) {
match ty {
Bool | Address | U8 | U64 | U128 | Signer | Struct(_) => (),
TypeParameter(idx) => {
type_params.insert(*idx);
}
Vector(ty) => rec(type_params, ty),
Reference(ty) | MutableReference(ty) => rec(type_params, ty),
StructInstantiation(_, tys) => {
for ty in tys {
rec(type_params, ty);
}
}
}
}
rec(&mut type_params, ty);
type_params
}
fn add_edge(&mut self, node_from: Node, node_to: Node, edge: Edge<'a>) {
let node_from_idx = self.get_or_add_node(node_from);
let node_to_idx = self.get_or_add_node(node_to);
self.graph.add_edge(node_from_idx, node_to_idx, edge);
}
fn build_graph_call(
&mut self,
caller_idx: FunctionDefinitionIndex,
callee_idx: FunctionDefinitionIndex,
type_actuals_idx: SignatureIndex,
) {
let type_actuals = &self.module.signature_at(type_actuals_idx).0;
for (formal_idx, ty) in type_actuals.iter().enumerate() {
let formal_idx = formal_idx as TypeParameterIndex;
match ty {
SignatureToken::TypeParameter(actual_idx) => self.add_edge(
Node(caller_idx, *actual_idx),
Node(callee_idx, formal_idx),
Edge::Identity,
),
_ => {
for type_param in self.extract_type_parameters(ty) {
self.add_edge(
Node(caller_idx, type_param),
Node(callee_idx, formal_idx),
Edge::TyConApp(ty),
);
}
}
}
}
}
fn build_graph_function_def(
&mut self,
caller_idx: FunctionDefinitionIndex,
caller_def: &FunctionDefinition,
) {
if let Some(code) = &caller_def.code {
for instr in &code.code {
if let Bytecode::CallGeneric(callee_inst_idx) = instr {
let callee_si = self.module.function_instantiation_at(*callee_inst_idx);
if let Some(callee_idx) = self.func_handle_def_map.get(&callee_si.handle) {
let callee_idx = *callee_idx;
self.build_graph_call(caller_idx, callee_idx, callee_si.type_parameters)
}
}
}
}
}
fn build_graph(&mut self) {
for (def_idx, func_def) in self
.module
.function_defs()
.iter()
.filter(|def| !def.is_native())
.enumerate()
{
self.build_graph_function_def(FunctionDefinitionIndex::new(def_idx as u16), func_def)
}
}
fn find_non_trivial_components(&self) -> Vec<(Vec<NodeIndex>, Vec<EdgeIndex>)> {
tarjan_scc(&self.graph)
.into_iter()
.filter_map(move |nodes| {
let node_set: HashSet<_> = nodes.iter().cloned().collect();
let edges: Vec<_> = nodes
.iter()
.flat_map(|node_idx| {
self.graph.edges(*node_idx).filter_map(|edge| {
if node_set.contains(&edge.target()) {
Some(edge.id())
} else {
None
}
})
})
.collect();
if edges.iter().any(
|edge_idx| match self.graph.edge_weight(*edge_idx).unwrap() {
Edge::Identity => false,
Edge::TyConApp(_) => true,
},
) {
Some((nodes, edges))
} else {
None
}
})
.collect()
}
fn format_node(&self, node_idx: NodeIndex) -> String {
let Node(def_idx, param_idx) = self.graph.node_weight(node_idx).unwrap();
format!("f{}#{}", def_idx, param_idx)
}
fn format_edge(&self, edge_idx: EdgeIndex) -> String {
let (node_idx_1, node_idx_2) = self.graph.edge_endpoints(edge_idx).unwrap();
let node_1 = self.format_node(node_idx_1);
let node_2 = self.format_node(node_idx_2);
match self.graph.edge_weight(edge_idx).unwrap() {
Edge::TyConApp(ty) => format!("{} --{:?}--> {}", node_1, ty, node_2,),
Edge::Identity => format!("{} ----> {}", node_1, node_2),
}
}
}